Fill 17.x/ReleaseNotes with my works#789
Conversation
ornata
left a comment
ornata
left a comment
There was a problem hiding this comment.
Added comments to make English prose more idiomatic.
llvm/docs/ReleaseNotes.rst
Outdated
| ``MVT``. | ||
|
|
||
| * ``Intrinsics.td`` is able to emit definitions of | ||
| ``TypeSig``. ``IntrinsicEmitter`` doesn't depend on |
There was a problem hiding this comment.
Suggestion:
IntrinsicEmitterno longer depends onMachineValueTypes.h
The sentence you wrote is correct. But the suggestion is more idiomatic.
There was a problem hiding this comment.
Looking at this again, I think this should be split into 3 bullet points:
Intrinsics.tdnow emitsTypeSigdefinitionsIntrinsicEmitterno longer depends onTypeSigIntrinsicEmitterno longer depends onMachineValueTypes.h
llvm/docs/ReleaseNotes.rst
Outdated
| ``TypeSig``. ``IntrinsicEmitter`` doesn't depend on | ||
| ``MachineValueTypes.h`` anymore. | ||
|
|
||
| * ``llvm/CodeGen/MachineValueType.h`` is moved from ``llvm/Support``. |
There was a problem hiding this comment.
is moved from
Do you mean removed from? Were the types in llvm/CodeGen/MachineValueType.h moved to ValueTypes.td?
There was a problem hiding this comment.
Oh, I see now. I think this would be clearer:
MachineValueType.his moved fromllvm/Supporttollvm/CodeGen.
llvm/docs/ReleaseNotes.rst
Outdated
|
|
||
| * ``llvm-min-tblgen`` is internally introduced to build LLVM public | ||
| headers. Note that ``llvm-tblgen`` depends on `GenVT.inc` that is | ||
| generated by ``llvm-min-tblgen``. Specify the external |
There was a problem hiding this comment.
How about
Builds using
LLVM_TABLEGENto specify a pre-built tablegen executable should usellvm-tblgen.
I think you can drop the part about llvm-tblgen being a superset of llvm-min-tblgen. It is implied above.
llvm/docs/ReleaseNotes.rst
Outdated
| Changes to building LLVM | ||
| ------------------------ | ||
|
|
||
| * ``llvm-min-tblgen`` is internally introduced to build LLVM public |
There was a problem hiding this comment.
"introduced internally" seems more natural than "internally introduced"
llvm/docs/ReleaseNotes.rst
Outdated
| ``name=value``. | ||
|
|
||
| * Each tablegen backend can declare itself as self-contained with | ||
| ``llvm::TableGen::Emitter`` as the registry. You don't need to |
There was a problem hiding this comment.
Prefer "users" to "you" in documentation.
llvm/docs/ReleaseNotes.rst
Outdated
|
|
||
| * Each tablegen backend can declare itself as self-contained with | ||
| ``llvm::TableGen::Emitter`` as the registry. You don't need to | ||
| append entries and options to ``TableGen.cpp``. For now, It is |
3 participants
Feel free to correct, rephrase, and revise this. Thank you,.